linux-kernel - Re: [PATCH] vsprintf: make %pV handling compatible with kasprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330966942.3140.8.camel@joe2Laptop>
Date:	Mon, 05 Mar 2012 09:02:22 -0800
From:	Joe Perches <joe@...ches.com>
To:	Jan Beulich <JBeulich@...e.com>
Cc:	akpm@...ux-foundation.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vsprintf: make %pV handling compatible with kasprintf()

On Mon, 2012-03-05 at 16:49 +0000, Jan Beulich wrote:
> kasprintf() (and potentially other functions that I didn't run across
> so far) want to evaluate argument lists twice. Caring to do so for the
> primary list is obviously their job, but they can't reasonably be
> expected to check the format string for instances of %pV, which however
> need special handling too: On architectures like x86-64 (as opposed to
> e.g. ix86), using the same argument list twice doesn't produce the
> expected results, as an internally managed cursor gets updated during
> the first run.
> 
> Fix the problem by always acting on a copy of the original list when
> handling %pV.

Wouldn't stable need this too?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/