linux-kernel - Re: [PATCH] KVM: PPC: check error return of kvmppc_core_vcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 05 Mar 2012 19:10:59 +0100
From:	Alexander Graf <agraf@...e.de>
To:	Ben Collins <bcollins@...ntu.com>
Cc:	kvm-ppc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: PPC: check error return of kvmppc_core_vcpu_create
 first

On 02/21/2012 05:30 AM, Ben Collins wrote:
> The result of kvmppc_core_vcpu_create() was being manipulated before it was checked for IS_ERR(). Did not see the bug occur, but caught it when looking through the code.

Nice catch, but this has already been fixed by Matt:

commit c6f3830e7313eea47b526b597aadc5b18c69ad55
Author: Matt Evans <matt@...abs.org>
Date:   Tue Dec 6 21:19:42 2011 +0000

     KVM: PPC: Fix vcpu_create dereference before validity check.

     Fix usage of vcpu struct before check that it's actually valid.

     Signed-off-by: Matt Evans <matt@...abs.org>
     Signed-off-by: Alexander Graf <agraf@...e.de>


Thanks a lot for sending the patch nevertheless!

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/