linux-kernel - Re: WARNING: Adjusting tsc more then 11%

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120305195619.GB17489@zod.bos.redhat.com>
Date:	Mon, 5 Mar 2012 14:56:19 -0500
From:	Josh Boyer <jwboyer@...hat.com>
To:	John Stultz <john.stultz@...aro.org>
Cc:	Dave Jones <davej@...hat.com>,
	Fedora Kernel Team <kernel-team@...oraproject.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: WARNING: Adjusting tsc more then 11%

On Mon, Mar 05, 2012 at 11:50:10AM -0800, John Stultz wrote:
> On Mon, 2012-03-05 at 14:23 -0500, Dave Jones wrote:
> > On Mon, Mar 05, 2012 at 10:32:03AM -0800, John Stultz wrote:
> >  > On Mon, 2012-03-05 at 10:44 -0500, Dave Jones wrote:
> > 
> >  > > any idea what could have changed to start tripping that up ?
> >  > > 
> >  > > The reports seem to have started around 3.3-rc4.
> >  > 
> >  > Huh. No I don't know what would have started causing such a warning. I
> >  > had expected that there would be some edge hardware that might trip that
> >  > warning, but I'd expect the noise to start there w/ 3.2 after it was
> >  > introduced. There's only been spelling & comment changes to the
> >  > timekeeping core in the 3.3-rc series.
> > 
> > thinking about this some more, while the reports starts around rc4, this
> > may have been caused by something prior to that, as anyone moving from
> > Fedora 16 or earlier to F17 alpha would have jumped quite a kernel version or two.
> 
> Was F16 3.1 based? The warning was added in 3.2, so if you skipped it,
> it may not be new behavior then.
> 
> >  > Do you know if this is an occasional thing on any of the affected
> >  > hardware, or if it happens after every reboot?
> > 
> > Out of all the people running the Fedora 17 alpha, this has only shown
> > up those four times, so it does seem to be a rare thing.
> > I suspect we'll get more instances of it as more people start testing.
> > 
> > Three of the reporters noted that it happened on boot.
> > 
> >  > Are any of the reported boxes systems you have access to in order to
> >  > reproduce?
> > 
> > unfortunately not.
> 
> Ok. Well, just to level set: the warning is informative, and points to
> unexpected, but not necessarily unsafe behavior.
> 
> In fact, the risk (where mult is adjusted to be large enough to cause an
> overflow) we're warning about have been present 2.6.36 or even possibly
> before. The change in 3.2 which added the warning also added a more
> conservative mult calculation, so we're less likely to get overflow
> prone large mult values.

Is there a reason you decided to use a WARN_ONCE, which dumps a full stack
trace, instead of just printk(KERN_ERR ?

> So it would be great to get further feedback from folks who are seeing
> this warning, so we can really hammer this out, but I don't want the
> warning spooking anyone into thinking things are terribly broken.

Right... people see backtraces and start thinking "my kernel is broken."

I'm certainly not meaning to pick on you for this.  Lately it seems all
the rage to throw WARN_ONs for all kinds of error paths and leave the user
to figure out how screwed they are.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/