linux-kernel - Re: [patch 5/8] x86: use this_cpu_xxx to replace percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120306075740.GF23669@elte.hu>
Date:	Tue, 6 Mar 2012 08:57:40 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	tglx@...utronix.de, hpa@...or.com, alex.shi@...el.com,
	cl@...two.org, sfr@...b.auug.org.au, tj@...nel.org,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [patch 5/8] x86: use this_cpu_xxx to replace percpu_xxx funcs


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Tue, 6 Mar 2012 08:46:01 +0100 Ingo Molnar <mingo@...e.hu> wrote:
> 
> > Will percpu_write() be removed altogether? If so then the 
> > changelog should say *that*, and explain that on x86 this is a 
> > simple renaming of the API, not a long explanation about 
> > scenarios that don't actually matter.
> > 
> > If percpu_write() is not being removed then I don't see how this 
> > patch is an improvement: it's supposed to result in the same 
> > instructions being emitted, and __this_cpu_write() et al are 
> > distinctly longer to write ...
> > 
> > So what's the plan here?
> 
> All percpu_xxx() functions get removed.

Fair enough - then please see my namespace comments for the 
other patch, before we start spreading these APIs to hundreds of 
places ...

Also, IMHO the lack of debugging API is troubling as well. 
Thomas found a couple of really, really hairy this_cpu related 
bugs.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/