linux-kernel - Re: [PATCH v5 0/3] KVM: perf: kvm events analysis tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F55EA0D.4040408@linux.vnet.ibm.com>
Date:	Tue, 06 Mar 2012 18:42:21 +0800
From:	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Avi Kivity <avi@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	David Ahern <dsahern@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v5 0/3] KVM: perf: kvm events analysis tool

Thanks for your review, Ingo!

On 03/06/2012 05:07 PM, Ingo Molnar wrote:


> So, your new tool has a similar workflow to:
> 
>   perf kvm record
>   perf kvm report
> 
> but differs from it in terms of events used and in terms of 
> reported output.
> 
> To me it appears that your tool is basically pretty similar to 
> 'perf stat', adapted to KVM, right?
> 
> So, could your new tool's workflow be simplified like this:
> 
>   perf kvm stat ..
> 
> ?
> 
> To automatically stat all vcpus in the system, the well-known 
> -a/--all-cpus system-wide method could be used:
> 
>   perf kvm stat -a ...
> 
> with stat output following immediately after it has finished.
> 


Actually, the stat information has already been included in the report.


> It should also be possible to use those new events in a 
> recording fashion - a new, rather logical command sub-space 
> could be used for that:
> 
>  perf kvm stat record ...
>  perf kvm stat report ...
> 
> [ This could be expanded to regular 'perf stat' as well: 'perf 
>   stat record' and 'perf stat report' would be useful - but I 
>   suspect that's outside the scope of your patches. ]
> 


I totally agree with you except i prefer 'perf kvm events' to
'perf kvm stat' :) : it records some specified kvm events and
smartly analyze it. I think it matches its doing better.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/