linux-kernel - Re: [PATCH] dma: dmaengine: Distinguish between 'dmaengine: failed to get' messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1331033498.24656.196.camel@vkoul-udesk3>
Date:	Tue, 06 Mar 2012 17:01:38 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	linux-kernel@...r.kernel.org, dan.j.williams@...el.com,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] dma: dmaengine: Distinguish between 'dmaengine: failed
 to get' messages

On Tue, 2012-02-21 at 12:51 -0200, Fabio Estevam wrote:
> The message "dmaengine: failed to get" can come from two possible locations within dmaengine.c.
> 
> In order to distinguish between them, replace "dmaengine" with __func__ string so that the
> source function of the error message can be easily identified.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
>  drivers/dma/dmaengine.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index a6c6051..ac10325 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -510,8 +510,8 @@ struct dma_chan *__dma_request_channel(dma_cap_mask_t *mask, dma_filter_fn fn, v
>  					 dma_chan_name(chan));
>  				list_del_rcu(&device->global_node);
>  			} else if (err)
> -				pr_debug("dmaengine: failed to get %s: (%d)\n",
> -					 dma_chan_name(chan), err);
> +				pr_debug("%s: failed to get %s: (%d)\n",
> +					__func__, dma_chan_name(chan), err);
>  			else
>  				break;
>  			if (--device->privatecnt == 0)
> @@ -564,8 +564,8 @@ void dmaengine_get(void)
>  				list_del_rcu(&device->global_node);
>  				break;
>  			} else if (err)
> -				pr_err("dmaengine: failed to get %s: (%d)\n",
> -				       dma_chan_name(chan), err);
> +				pr_err("%s: failed to get %s: (%d)\n",
> +					__func__, dma_chan_name(chan), err);
>  		}
>  	}
>  
Applied, Thanks

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/