| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201203061602.23512.arnd@arndb.de> Date: Tue, 6 Mar 2012 16:02:23 +0000 From: Arnd Bergmann <arnd@...db.de> To: Mark Salter <msalter@...hat.com> Cc: "linux-kernel" <linux-kernel@...r.kernel.org>, "linux-next" <linux-next@...r.kernel.org>, "linux-arch" <linux-arch@...r.kernel.org> Subject: Re: lib/string.h build failure in linux-next On Tuesday 06 March 2012, Mark Salter wrote: > I'm seeing a build failure in lib/string.h in linux-next: > > /es/linux/linux-next/lib/string.c: In function 'strlcat': > /es/linux/linux-next/lib/string.c:225:2: error: implicit declaration of function 'printk' > /es/linux/linux-next/lib/string.c:225:2: error: implicit declaration of function 'panic' > > Commit e2950c2b6ecb928bfd3a13dd237df1f29f712704 removed an include of > linux/module.h which triggered the problem for arch/c6x and probably > other architectures using the asm-generic BUG macro. > > I think this needs fixing in asm-generic/bug.h which should include > linux/kernel.h for panic and linux/printk.h for printk. I think you cannot do that as long as linux/kernel.h includes asm/bug.h, or you will get a lot of other build failures. The safer option is probably to add the two missing headers separately to string.c. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists