linux-kernel - Re: [PATCH 0001/001] xen: multi page ring support for block devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ty22xxee.fsf@rustcorp.com.au>
Date:	Tue, 06 Mar 2012 13:12:49 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Santosh Jodh <Santosh.Jodh@...rix.com>,
	"konrad.wilk\@oracle.com" <konrad.wilk@...cle.com>,
	"jeremy\@goop.org" <jeremy@...p.org>,
	Ian Campbell <Ian.Campbell@...rix.com>,
	"jbarnes\@virtuousgeek.org" <jbarnes@...tuousgeek.org>,
	"jbeulich\@novell.com" <jbeulich@...ell.com>,
	"joe.jin\@oracle.com" <joe.jin@...cle.com>,
	"lersek\@redhat.com" <lersek@...hat.com>,
	"weiyi.huang\@gmail.com" <weiyi.huang@...il.com>,
	"dgdegra\@tycho.nsa.gov" <dgdegra@...ho.nsa.gov>,
	David Vrabel <david.vrabel@...rix.com>,
	"paul.gortmaker\@windriver.com" <paul.gortmaker@...driver.com>,
	"akpm\@linux-foundation.org" <akpm@...ux-foundation.org>,
	"waldi\@debian.org" <waldi@...ian.org>,
	"virtualization\@lists.linux-foundation.org" 
	<virtualization@...ts.linux-foundation.org>,
	"netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
	"linux-pci\@vger.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"xen-devel\@lists.xen.org" <xen-devel@...ts.xen.org>
Cc:	Santosh Jodh <Santosh.Jodh@...rix.com>,
	Paul Durrant <Paul.Durrant@...rix.com>
Subject: Re: [PATCH 0001/001] xen: multi page ring support for block devices

On Mon, 5 Mar 2012 13:49:07 -0800, Santosh Jodh <Santosh.Jodh@...rix.com> wrote:
> +/* Order of maximum shared ring size advertised to the front end. */
> +int xen_blkif_max_ring_order = XENBUS_MAX_RING_ORDER;
> +
> +#define BLK_RING_SIZE(_order) __CONST_RING_SIZE(blkif, PAGE_SIZE << (_order))
> +
> +static int set_max_ring_order(const char *buf, struct kernel_param *kp)
> +{
> +       int err;
> +       unsigned long order;
> +
> +       err = kstrtol(buf, 0, &order);
> +       if (err ||
> +           order < 0 ||
> +           order > XENBUS_MAX_RING_ORDER)
> +               return -EINVAL;

Hmm, order can't be < 0, since it's unsigned.  So did you mean
kstrtoull?

And I think returning err is cleaner (it's -EINVAL for malformed
strings, -ERANGE for ones too big).

> +       if (xen_blkif_reqs < BLK_RING_SIZE(order))
> +               printk(KERN_WARNING "WARNING: "
> +                      "I/O request space (%d reqs) < ring order %ld, "
> +                      "consider increasing %s.reqs to >= %ld.",
> +                      xen_blkif_reqs, order, KBUILD_MODNAME,
> +                      roundup_pow_of_two(BLK_RING_SIZE(order)));

This message doesn't mention the module namr or parameter name
anywhere.  Think of the poor sysadmins!

Thanks,
Rusty.
-- 
  How could I marry someone with more hair than me?  http://baldalex.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/