linux-kernel - Re: [PATCHv2 3/3] misc: rename bmp085 to bmp18x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201203062114.30998.arnd@arndb.de>
Date:	Tue, 6 Mar 2012 21:14:30 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Eric Andersson <eric.andersson@...xphere.com>
Cc:	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	alan@...rguk.ukuu.org.uk, zhengguang.guo@...ch-sensortec.com,
	peter.moeller@...bosch.com
Subject: Re: [PATCHv2 3/3] misc: rename bmp085 to bmp18x

On Tuesday 06 March 2012, Eric Andersson wrote:
> The bmp085 chip has been deprecated by the newer bmp18x chip family from
> Bosch Sensortec.
> 
> Reviewed-by: Stefan Nilsson <stefan.nilsson@...xphere.com>
> Signed-off-by: Eric Andersson <eric.andersson@...xphere.com>
> ---
>  drivers/misc/Kconfig       |   18 +-
>  drivers/misc/Makefile      |    6 +-
>  drivers/misc/bmp085.c      |  514 --------------------------------------------
>  drivers/misc/bmp18x-i2c.c  |  132 +++++++++++
>  drivers/misc/bmp18x-spi.c  |  140 ++++++++++++
>  drivers/misc/bmp18x.c      |  512 +++++++++++++++++++++++++++++++++++++++++++
>  include/linux/i2c/bmp085.h |   63 ------
>  include/linux/i2c/bmp18x.h |   63 ++++++
>  8 files changed, 859 insertions(+), 589 deletions(-)

Please use 'git format-patch -M' when sending a rename patch, to make it obvious
that there are no code changes in the rename. It's a bit suspicous that
the files are different size and that you remove one .c file but add three
other ones.

You should also try give a better explanation why the rename is actually a
good idea. Simply listing the old model as deprecated does not sound like
a strong enough reason, given that some people might rely on the existing
name in user space interfaces.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/