linux-kernel - Re: [PATCH bisected regression] sched: rebuild sched domains at suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F5685E9.4010900@openvz.org>
Date:	Wed, 07 Mar 2012 01:47:21 +0400
From:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	Ingo Molnar <mingo@...e.hu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Subject: Re: [PATCH bisected regression] sched: rebuild sched domains at suspend/resume

Peter Zijlstra wrote:
> On Wed, 2012-03-07 at 00:45 +0400, Konstantin Khlebnikov wrote:
>> This is fix for suspend/resume regression introduced in commit 8f2f748b0656
>> ("CPU hotplug, cpusets, suspend: Don't touch cpusets during suspend/resume")
>> Without this patch suspend always hangs on my thinkpad x220 (2 x CPU * HT).
>>
>> cpuset_update_active_cpus() not only juggles with bits in cpusets,
>> it also calls sched-domains rebuilding after all.
>>
>> This patch restores sched-domain rebuilds, as it was before that commit.
>
> This changelog also completely fails to explain what the problem was and
> how this patch sorts it without re-introducing the problems 8f2f748b0656
> was supposed to fix.

That patch removes cpuset bits clearing on suspend/resume cycle. My patch doesn't clear them too.
I don't know why these domain rebuilds are required, so I just returned them back.

>
> I'd rather revert the 'fix' and think about this more (its been broken
> pretty much forever anyway) than tinker on top like this.

Ok, "rc" isn't the best time that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/