linux-kernel - Re: [ANNOUNCE] 3.2.9-rt15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F558F74.5050704@localhost>
Date:	Mon, 05 Mar 2012 20:15:48 -0800
From:	Fernando Lopez-Lezcano <nando@...ma.Stanford.EDU>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	Clark Williams <clark@...hat.com>,
	"Luis Claudio R. Goncalves" <lclaudio@...g.org>,
	Fernando Lopez-Lezcano <nando@...ma.Stanford.EDU>
Subject: Re: [ANNOUNCE] 3.2.9-rt15

On 03/05/2012 02:14 PM, Steven Rostedt wrote:
> Thomas,
>
> Please fold this change into
>
>     cpu-rt-make-hotplug-lock-a-sleeping-spinlock-on-rt.patch

Thanks, this fixed the panic on shutdown I was experiencing!
-- Fernando


> As the patch was never tested (nor even compiled) it introduced a nasty
> bug into taking a CPU down instead of fixing one.
>
> Thanks,
>
> -- Steve
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index c25b5ff..66dfb74 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -59,16 +59,20 @@ static struct {
>   	int refcount;
>   } cpu_hotplug = {
>   	.active_writer = NULL,
> +#ifdef CONFIG_PREEMPT_RT_FULL
> +	.lock = __SPIN_LOCK_UNLOCKED(cpu_hotplug.lock),
> +#else
>   	.lock = __MUTEX_INITIALIZER(cpu_hotplug.lock),
> +#endif
>   	.refcount = 0,
>   };
>
>   #ifdef CONFIG_PREEMPT_RT_FULL
> -# define hotplug_lock() spin_lock(&cpu_hotplug.lock)
> -# define hotplug_unlock() spin_unlock(&cpu_hotplug.lock)
> +# define hotplug_lock() rt_spin_lock(&cpu_hotplug.lock)
> +# define hotplug_unlock() rt_spin_unlock(&cpu_hotplug.lock)
>   #else
>   # define hotplug_lock() mutex_lock(&cpu_hotplug.lock)
> -# define hotplug_lock() mutex_unlock(&cpu_hotplug.lock)
> +# define hotplug_unlock() mutex_unlock(&cpu_hotplug.lock)
>   #endif
>
>   struct hotplug_pcp {
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/