linux-kernel - Re: [PATCH 05/68] TTY: remove re-assignments to tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F56A2A5.7010707@imap.cc>
Date:	Wed, 07 Mar 2012 00:49:57 +0100
From:	Tilman Schmidt <tilman@...p.cc>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	gregkh@...uxfoundation.org, alan@...ux.intel.com,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	jirislaby@...il.com
Subject: Re: [PATCH 05/68] TTY: remove re-assignments to tty_driver members

Am 05.03.2012 14:51, schrieb Jiri Slaby:
> All num, magic and owner are set by alloc_tty_driver. No need to
> re-set them on each allocation site.

Nice.

> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

For drivers/isdn/gigaset:

Acked-by: Tilman Schmidt <tilman@...p.cc>

> diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
> index b826dac..7e54577 100644
> --- a/drivers/isdn/gigaset/interface.c
> +++ b/drivers/isdn/gigaset/interface.c
> @@ -669,17 +669,15 @@ EXPORT_SYMBOL_GPL(gigaset_if_receive);
>  void gigaset_if_initdriver(struct gigaset_driver *drv, const char *procname,
>  			   const char *devname)
>  {
> -	unsigned minors = drv->minors;
>  	int ret;
>  	struct tty_driver *tty;
>  
>  	drv->have_tty = 0;
>  
> -	drv->tty = tty = alloc_tty_driver(minors);
> +	drv->tty = tty = alloc_tty_driver(drv->minors);
>  	if (tty == NULL)
>  		goto enomem;
>  
> -	tty->magic =		TTY_DRIVER_MAGIC;
>  	tty->type =		TTY_DRIVER_TYPE_SERIAL;
>  	tty->subtype =		SERIAL_TYPE_NORMAL;
>  	tty->flags =		TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV;
> @@ -687,9 +685,6 @@ void gigaset_if_initdriver(struct gigaset_driver *drv, const char *procname,
>  	tty->driver_name =	procname;
>  	tty->name =		devname;
>  	tty->minor_start =	drv->minor;
> -	tty->num =		drv->minors;
> -
> -	tty->owner =		THIS_MODULE;
>  
>  	tty->init_termios          = tty_std_termios;
>  	tty->init_termios.c_cflag  = B9600 | CS8 | CREAD | HUPCL | CLOCAL;

Thanks,
Tilman

-- 
Tilman Schmidt                    E-Mail: tilman@...p.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


Download attachment "signature.asc" of type "application/pgp-signature" (260 bytes)