linux-kernel - Re: [PATCH] [media] dvb: negative value assigned to unsigned int in CDRXD().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120307061254.GQ22598@mwanda>
Date:	Wed, 7 Mar 2012 09:12:54 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	santosh nayak <santoshprasadnayak@...il.com>
Cc:	mchehab@...radead.org, dheitmueller@...nellabs.com,
	hans.verkuil@...co.com, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] [media] dvb: negative value assigned to unsigned int in
 CDRXD().

On Wed, Mar 07, 2012 at 09:11:03AM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@...il.com>
> 
> In CDRXD(), Negative number is assigned to unsigned variable
> 'state->noise_cal.tdCal2.
> 
> Members of 'SNoiseCal' should be 'signed short'.
> 

In your changelogs could you please write something about how this
change will affect what the user sees.  That way users know if it
fixes something they care about and they will apply your patch.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)