linux-kernel - Re: [PATCH v10 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHQjnOOQKS1EU-3zWDDq2sLxPucY9CRZyrnaT5cyyrSa9-k9Nw@mail.gmail.com>
Date:	Wed, 7 Mar 2012 15:22:33 +0900
From:	KyongHo Cho <pullip.cho@...sung.com>
To:	InKi Dae <daeinki@...il.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org,
	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	Kukjin Kim <kgene.kim@...sung.com>,
	Joerg Roedel <joro@...tes.org>,
	Subash Patel <subash.ramaswamy@...aro.org>,
	Younglak Kim <younglak1004.kim@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Sanghyun Lee <sanghyun75.lee@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v10 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

On Wed, Mar 7, 2012 at 2:28 PM, InKi Dae <daeinki@...il.com> wrote:
>> +static irqreturn_t exynos_sysmmu_irq(int irq, void *dev_id)
>> +{
>> +       /* SYSMMU is in blocked when interrupt occurred. */
>> +       struct sysmmu_drvdata *data = dev_id;
>> +       struct resource *irqres;
>> +       struct platform_device *pdev;
>> +       enum EXYNOS_SYSMMU_INTERRUPT_TYPE itype;
>
> how about to change EXYNOS_SYSMMU_INTERRUPT_TYPE to small letter? just
> for code clean.
>
I will. please refer to the my reply to Kyungmin Park.

>> +       unsigned long addr = -1;
>> +
>> +       int i, ret = -ENOSYS;
>> +
>> +       read_lock(&data->lock);
>> +
>> +       WARN_ON(!is_sysmmu_active(data));
>> +
>> +       pdev = to_platform_device(data->sysmmu);
>> +       for (i = 0; i < pdev->num_resources; i++) {
>> +               irqres = platform_get_resource(pdev, IORESOURCE_IRQ, i);
>> +               if (irqres && ((int)irqres->start == irq))
>> +                       break;
>> +       }
>
> is there any reason that it should get irq resources in interrupt
> handler? if not so then how about to move it into probe()?
>
The platform device of ISP has a lot of IRQ sources.
The above for clause determines which IRQ source (System MMU)
generated the interrupt.

>> +
>> +       if (i == pdev->num_resources) {
>> +               itype = SYSMMU_FAULT_UNKNOWN;
>> +       } else {
>> +               i /= 2;
>> +
>> +               itype = (enum EXYNOS_SYSMMU_INTERRUPT_TYPE)
>
> ditto.
>

Thank you.

Cho KyongHo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/