linux-kernel - Re: [PATCH] uevent: send events in correct order according to seqnum (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPXgP13+Av39cFMxU1YNNPEc=yMjRV-pCXf-r_RHcNtDQ-xESw@mail.gmail.com>
Date:	Wed, 7 Mar 2012 11:18:47 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Andrew Vagin <avagin@...nvz.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-hotplug@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uevent: send events in correct order according to seqnum (v2)

On Wed, Mar 7, 2012 at 10:59, Andrew Vagin <avagin@...nvz.org> wrote:
> The queue handling in the udev daemon assumes that the events are
> ordered.

> -       retval = add_uevent_var(env, "SEQNUM=%llu", (unsigned long long)seq);
> +       retval = add_uevent_var(env, "SEQNUM=%llu", (unsigned long long)++uevent_seqnum);
>        if (retval)
>                goto exit;

We need to unlock the mutex before the goto exit?

Other than that, looks good to me.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/