linux-kernel - Re: [PATCH] uevent: send events in correct order according to seqnum (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPXgP12kQm9dZdjh3Vch2ebrn21jW6r-=gVssmvU3WqJ6VE70g@mail.gmail.com>
Date:	Wed, 7 Mar 2012 12:03:19 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Andrew Vagin <avagin@...nvz.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-hotplug@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uevent: send events in correct order according to seqnum (v3)

On Wed, Mar 7, 2012 at 11:49, Andrew Vagin <avagin@...nvz.org> wrote:
> The queue handling in the udev daemon assumes that the events are
> ordered.
>
> Before this patch uevent_seqnum is incremented under sequence_lock,
> than an event is send uner uevent_sock_mutex. I want to say that code
> contained a window between incrementing seqnum and sending an event.
>
> This patch locks uevent_sock_mutex before incrementing uevent_seqnum.
>
> v2: delete sequence_lock, uevent_seqnum is protected by uevent_sock_mutex
> v3: unlock the mutex before the goto exit
>
> Thanks for Kay for the comments.
>
> Signed-off-by: Andrew Vagin <avagin@...nvz.org>

Looks good to me. Works fine in a kvm installation here.
Feel free to add:
  Tested-By: Kay Sievers <kay.sievers@...y.org>

Thanks lot for the udev debugging and taking care of it,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/