linux-kernel - Re: [PATCH 4/9] drm/i915/intel_i2c: cleanup gmbus/gpio pin assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Mar 2012 20:44:15 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	Chris Wilson <chris@...is-wilson.co.uk>
Cc:	Keith Packard <keithp@...thp.com>, David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Benson Leung <bleung@...omium.org>,
	Yufeng Shen <miletus@...omium.org>,
	Sameer Nanda <snanda@...omium.org>
Subject: Re: [PATCH 4/9] drm/i915/intel_i2c: cleanup gmbus/gpio pin assignments

On Wed, Mar 7, 2012 at 8:17 PM, Chris Wilson <chris@...is-wilson.co.uk> wrote:
> On Wed,  7 Mar 2012 19:50:45 +0800, Daniel Kurtz <djkurtz@...omium.org> wrote:
>> There is no "disabled" port 0.  So, don't even try to initialize/scan
>> it, etc.  This saves a bit of time when initializing the driver, since
>> the we can avoid a 50ms timeout waiting for a device to respond on
>> a port that doesn't even exist.
>>
>> Similarly, don't initialize the reserved port, either.
>
>> @@ -150,32 +164,23 @@ static void set_data(void *data, int state_high)
>>  static struct i2c_adapter *
>>  intel_gpio_create(struct drm_i915_private *dev_priv, u32 pin)
>>  {
>> -     static const int map_pin_to_reg[] = {
>> -             0,
>> -             GPIOB,
>> -             GPIOA,
>> -             GPIOC,
>> -             GPIOD,
>> -             GPIOE,
>> -             GPIOF,
>> -             0,
>> -     };
>>       struct intel_gpio *gpio;
>>
>> -     if (pin >= ARRAY_SIZE(map_pin_to_reg) || !map_pin_to_reg[pin])
>
> And that doesn't do what your changelog proposes? Why?

This changelog proposes to optimize initialization of the gmbus ports,
not the gpio-bit-bang ports.

> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/