linux-kernel - Re: [PATCH v10 2/3] ARM: EXYNOS: Change System MMU platform device definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHQjnOP_mEck35PwhDd7v=MKc+ONFRFxa7i=ro0iMxWy-fuFNw@mail.gmail.com>
Date:	Wed, 7 Mar 2012 09:10:42 +0900
From:	KyongHo Cho <pullip.cho@...sung.com>
To:	Kyungmin Park <kyungmin.park@...sung.com>
Cc:	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Subash Patel <subash.ramaswamy@...aro.org>,
	Younglak Kim <younglak1004.kim@...sung.com>,
	iommu@...ts.linux-foundation.org,
	Kukjin Kim <kgene.kim@...sung.com>,
	Sanghyun Lee <sanghyun75.lee@...sung.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v10 2/3] ARM: EXYNOS: Change System MMU platform device definitions

On Tue, Mar 6, 2012 at 7:03 PM, Kyungmin Park <kyungmin.park@...sung.com> wrote:
>>
>> -#define S5P_SYSMMU_TOTAL_IPNUM               EXYNOS4_SYSMMU_TOTAL_IPNUM
>> +#define SYSMMU_DEVNAME_BASE "exynos-sysmmu"
>> +
>> +#define SYSMMU_CLOCK_NAME "sysmmu"
>> +#define SYSMMU_CLOCK_NAME2 "sysmmu_mc"
> What's the meaning of "mc"?
It stands for multi clock gating source.
ISP block has a lot of System MMUs and I merged them in a single
platform device to control them easier. However it is required to access
2 control registers to gating  their clocks. "sysmmu_mc" is prepared for the
case that requires 2 clock descriptors for clock gating.

>> +
>> +#ifdef CONFIG_EXYNOS_DEV_SYSMMU
>> +#include <linux/device.h>
>> +struct platform_device;
>> +
>> +#define SYSMMU_PLATDEV(ipname) exynos_device_sysmmu_##ipname
>> +
>> +extern struct platform_device SYSMMU_PLATDEV(mfc_l);
>> +extern struct platform_device SYSMMU_PLATDEV(mfc_r);
>> +extern struct platform_device SYSMMU_PLATDEV(tv);
>> +extern struct platform_device SYSMMU_PLATDEV(jpeg);
>> +extern struct platform_device SYSMMU_PLATDEV(rot);
> Where's the fimc platform_device?
>
> I think you only tested it with exynos5.

True. I am sorry that I have missed to define it externally.
Thank you.

Cho KyongHo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/