linux-kernel - Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120307173922.GB1130@pengutronix.de>
Date:	Wed, 7 Mar 2012 18:39:22 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Laxman Dewangan <ldewangan@...dia.com>, khali@...ux-fr.org,
	ben-linux@...ff.org, grant.likely@...retlab.ca,
	linus.walleij@...aro.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver

On Wed, Mar 07, 2012 at 05:31:57PM +0000, Mark Brown wrote:
> On Wed, Mar 07, 2012 at 07:08:14PM +0530, Laxman Dewangan wrote:
> > The gpio core driver (gpio library) supports the open
> > drain pin handling. Therefore, it is not require it
> > to handle in the i2c-gpio driver, just require
> > to pass the OPEN_DRAIN type flag when requesting the gpio.
> 
> Reviwed-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

Typo ;)

> 
> but note that this is a new gpiolib feature in -next and will need to
> either be applied via Grant's tree or wait until after the merge window.

I'll pick it for v3.5 later. Thanks for the review!

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)