linux-kernel - Re: [PATCH 1/2] core dump: drop VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F57D296.8090608@tilera.com>
Date:	Wed, 7 Mar 2012 16:26:46 -0500
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Jason Baron <jbaron@...hat.com>
CC:	Roland McGrath <roland@...k.frob.com>, <akpm@...ux-foundation.org>,
	<avi@...hat.com>, <linux-kernel@...r.kernel.org>,
	<qemu-devel@...gnu.org>
Subject: Re: [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag

On 3/7/2012 4:19 PM, Jason Baron wrote:
> On Wed, Mar 07, 2012 at 11:43:02AM -0800, Roland McGrath wrote:
>>> well, sure, we can provide an arch interface, for this check. I'm more
>>> concerned with the general idea. If it seems ok, I can re-do this bit
>>> with an arch interface.
>> Anything based on strcmp is dismal.  VM_ALWAYSDUMP was nice and clean.
>> A hook along the lines of arch_vma_name would be clean enough I suppose.
>> In fact, there is only one instance today (tile) where arch_vma_name()!=NULL
>> wouldn't do just what you need.
>>
> Yeah, so I think something like the following would work (adding Tile
> maintainer to 'cc list).

Thanks!

My instinct would be not to special-case it in always_dump_vma().  Since
it's just a one-page region anyway, and it is at least potentially
interesting, I'm happy to always dump it.  Alternately, we can just get rid
of the "[intrpt]" name, which I just put in to be cute (and since it was
easy to identify the mapping in question).  Regardless, since that region
doesn't exist on our current 64-bit architecture, I'm not too concerned
with how it's handled going forward, since I expect the 32-bit platform to
become less popular over time.  I'd vote for generic code cleanliness.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/