lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 7 Mar 2012 12:16:37 +0800
From:	Axel Lin <>
Cc:	Sangbeom Kim <>, Liam Girdwood <>,
	Mark Brown <>
Subject: Re: [PATCH] regulator: Rename s5m8767_convert_voltage to s5m8767_get_proper_voltage_sel

2012/3/7 Axel Lin <>:
> This function finds the smallest voltage that falls within the specified range,
> and then returns the selector. This rename makes the intention more clear.
> Also remove unneeded local variables min_vol and max_vol in s5m8767_set_voltage
> and s5m8767_set_voltage_buck.
> Signed-off-by: Axel Lin <>
> ---
> I was confused by the function name, s5m8767_convert_voltage() converts what to what?

BTW, I'm also confused by s5m8767_set_high and s5m8767_set_low functions.
Both function sets the same gpios to the same state. ( by different order )
Maybe we need comments (or rename) for both functions.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists