linux-kernel - RE: [PATCH v2] powerpc/srio: Fix the compile errors when building with 64bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1331188278.23420.157.camel@10.ap.freescale.net>
Date:	Thu, 8 Mar 2012 14:31:17 +0800
From:	Liu Gang <Gang.Liu@...escale.com>
To:	David Laight <David.Laight@...LAB.COM>
CC:	<linuxppc-dev@...ts.ozlabs.org>, <Alexandre.Bounine@....com>,
	<r58472@...escale.com>, <linux-kernel@...r.kernel.org>,
	<r61911@...escale.com>, <paul.gortmaker@...driver.com>,
	<akpm@...ux-foundation.org>,
	Shaohui Xie <Shaohui.Xie@...escale.com>
Subject: RE: [PATCH v2] powerpc/srio: Fix the compile errors when building
	with 64bit

Hi, David,

On Wed, 2012-03-07 at 13:18 +0000, David Laight wrote:  
> >  	pr_debug("RIO: fsl_add_outb_message(): destid %4.4x mbox %d
> buffer " \
> > -		 "%8.8x len %8.8x\n", rdev->destid, mbox, (int)buffer,
> len);
> > +		 "%8.8lx len %8.8zx\n", rdev->destid, mbox,
> > +		(unsigned long)buffer, len);
> 
> Should 'buffer' be printed with %p ??

Yes, printing with "%p" can get rid of the cast, although they have the
same print results.

Thanks a lot.

Liu Gang


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/