linux-kernel - Re: [PATCH 1/3] drivers: base: add support for stmp-style devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120308074510.GB18510@pengutronix.de>
Date:	Thu, 8 Mar 2012 08:45:10 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Fabio Estevam <festevam@...il.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Arnd Bergmann <arnd@...db.de>, Greg KH <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, Huang Shijie <b32955@...escale.com>,
	Shawn Guo <shawn.guo@...aro.org>
Subject: Re: [PATCH 1/3] drivers: base: add support for stmp-style devices

On Wed, Mar 07, 2012 at 07:40:22PM -0300, Fabio Estevam wrote:
> On Wed, Mar 7, 2012 at 7:28 PM, Wolfram Sang <w.sang@...gutronix.de> wrote:
> ...
> > +static int stmp_clear_poll_bit(void __iomem *addr, u32 mask)
> > +{
> > +       int timeout = 0x400;
> 
> Could you please add a proper timeout mechanism here?
> 
> Something like: http://patchwork.ozlabs.org/patch/137365/

From the patch description:

===

To avoid regressions and ease reviewing, the actual code is simply copied from
mach-mxs. It definately wants updates, but those need a seperate patch series.

===

Or is that considered a wrong path?

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)