linux-kernel - Re: [PATCH] kvm: svm: count all irq windows exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120308104038.GQ10684@amd.com>
Date:	Thu, 8 Mar 2012 11:40:38 +0100
From:	Joerg Roedel <joerg.roedel@....com>
To:	Jason Wang <jasowang@...hat.com>
CC:	<mtosatti@...hat.com>, <avi@...hat.com>, <kvm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kvm: svm: count all irq windows exit

On Thu, Mar 08, 2012 at 06:07:56PM +0800, Jason Wang wrote:
> Also count the exits of fast-path.

And align it with how it is counted in VMX.

> Signed-off-by: Jason Wang <jasowang@...hat.com>

Acked-by: Joerg Roedel <joerg.roedel@....com>

> ---
>  arch/x86/kvm/svm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 53efd59..5ef7233 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -3235,6 +3235,7 @@ static int interrupt_window_interception(struct vcpu_svm *svm)
>  	svm_clear_vintr(svm);
>  	svm->vmcb->control.int_ctl &= ~V_IRQ_MASK;
>  	mark_dirty(svm->vmcb, VMCB_INTR);
> +	++svm->vcpu.stat.irq_window_exits;
>  	/*
>  	 * If the user space waits to inject interrupts, exit as soon as
>  	 * possible
> @@ -3242,7 +3243,6 @@ static int interrupt_window_interception(struct vcpu_svm *svm)
>  	if (!irqchip_in_kernel(svm->vcpu.kvm) &&
>  	    kvm_run->request_interrupt_window &&
>  	    !kvm_cpu_has_interrupt(&svm->vcpu)) {
> -		++svm->vcpu.stat.irq_window_exits;
>  		kvm_run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN;
>  		return 0;
>  	}
> 

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/