linux-kernel - Re: [PATCH] x86,nmi: Fix page faults by nmiaction if kmemcheck is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1331235766.11248.404.camel@twins>
Date:	Thu, 08 Mar 2012 20:42:46 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Don Zickus <dzickus@...hat.com>
Cc:	x86@...nel.org, LKML <linux-kernel@...r.kernel.org>,
	Li Zhong <zhong@...ux.vnet.ibm.com>
Subject: Re: [PATCH] x86,nmi: Fix page faults by nmiaction if kmemcheck is
 enabled

On Thu, 2012-03-08 at 14:17 -0500, Don Zickus wrote:

> +int __register_nmi_handler(unsigned int type, unsigned int nmiflags,
> +                                               struct nmiaction *na)
>  {
> +       if (!na->handler)
>                 return -EINVAL;
>  
> +       na->flags = nmiflags;
>  
> +       return __setup_nmi(type, na);
>  }
> +EXPORT_SYMBOL_GPL(__register_nmi_handler);

Put the na->flags thing in the CPP bit, put the !handler check in
__setup_nmi() and loose the pointless wrappery?

>  void unregister_nmi_handler(unsigned int type, const char *name)
>  {
> +       __free_nmi(type, name);
>  }
>  
>  EXPORT_SYMBOL_GPL(unregister_nmi_handler); 

That's another quite pointless wrapper there..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/