linux-kernel - Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120308142257.145e0968@redhat.com>
Date:	Thu, 8 Mar 2012 14:22:57 -0600
From:	Clark Williams <williams@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	John Kacur <jkacur@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	rt-users <linux-rt-users@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH-RT] preempt.h: Fix implicit declaration of
 'preempt_check_resched_rt'

On Thu, 08 Mar 2012 15:17:20 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote:
> > When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
> > defined the following build break occurs.
> > 
> > /home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
> > /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
> > make[2]: *** [block/blk-softirq.o] Error 1
> > make[1]: *** [block/blk-softirq.o] Error 2
> > make: *** [sub-make] Error 2
> > 
> > This patch fixes the build error by adding a define to the
> > !CONFIG_PREEMPT_COUNT section.
> > 
> > Signed-off-by: Clark Williams <williams@...hat.com>
> 
> Why Clark's SOB? Did he write it and send it to you?

I suppose to be technically correct it should have been a Tested-by:

John found it while I was working on it and I tested it for him.

Clark

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)