linux-kernel - Re: [RFC] c/r: prctl: Add ability to set new mm_struct::exe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Mar 2012 12:24:38 -0800
From:	Andy Lutomirski <luto@...capital.net>
To:	Cyrill Gorcunov <gorcunov@...nvz.org>
Cc:	Kees Cook <keescook@...omium.org>, Oleg Nesterov <oleg@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Will Drewry <wad@...omium.org>
Subject: Re: [RFC] c/r: prctl: Add ability to set new mm_struct::exe_file v3

On Thu, Mar 8, 2012 at 12:21 PM, Cyrill Gorcunov <gorcunov@...nvz.org> wrote:
> On Thu, Mar 08, 2012 at 12:15:55PM -0800, Andy Lutomirski wrote:
>> On Thu, Mar 8, 2012 at 12:07 PM, Cyrill Gorcunov <gorcunov@...nvz.org> wrote:
>> > On Thu, Mar 08, 2012 at 12:02:50PM -0800, Andy Lutomirski wrote:
>> >> >
>> >> > I can do that if Andrew agree.
>> >>
>> >> I'm a bit lost.  nnp updates the MNT_NOSUID checks, not the MNT_NOEXEC
>> >> checks.  (And the effects of the two flags is different in selinux for
>> >> historical reasons.)  I'm sure I'm missing something.
>> >>
>> >
>> > Andy, I've no idea what nnp is ;) I was only about to gather those
>> > ISREG/MNT_NOEXEC to one helper since we indeed have a few places in
>> > kernel which do same thing in open-coded manner.
>>
>> Am I not the Andrew you were referring to?
>>
>
> Nope, I meant Andrew Morton /because this patch is for -mm/ ;)
>
> I've been in To: field that's why I replied you about nnp
> (and, btw, what nnp is? not "Net national product" I suppose,
>  this hint wikipedia gave me)

nnp is no_new_privs, which is my patch and is almost, but not quite,
very relevant to this discussion.  Hence my confusion ;)

FWIW, since I've touched this code recently, the cleanup you're
suggesting sounds good.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/