linux-kernel - Re: [PATCH] staging:iio:tsl2563 rewrite probe error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120309062358.GA3337@mwanda>
Date:	Fri, 9 Mar 2012 09:23:58 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Grant Grundler <grundler@...omium.org>
Cc:	Jonathan Cameron <jic23@...nel.org>, devel@...verdev.osuosl.org,
	linux-iio@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Bryan Freed <bfreed@...omium.org>,
	Jonathan Cameron <jic23@....ac.uk>,
	Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH] staging:iio:tsl2563 rewrite probe error handling

On Thu, Mar 08, 2012 at 07:51:07PM -0800, Grant Grundler wrote:
> Hi Jonathan!
> 
> On Wed, Mar 7, 2012 at 3:28 AM, Jonathan Cameron <jic23@...nel.org> wrote:
> > Fundamentally an excellent patch fixing some real issues,
> 
> Thank you! :)
> 
> > but just
> > because I'm in that sort of mood I'll be fussy about the fact it is
> > one patch.
> >
> > To nitpick, I'd have prefered this to be two patches. First that fixes
> > the issues and the second that adds the additional output.  Actually
> > should probably have even had a third making the white space changes.
> 
> Yup - I see/understand why. I need to improve my git foo and work
> habits so it's not hard to play with a series of smaller patches
> rather than one patch that does everything to one function.
> 

If you use git citool then you can just highlight and right click on
the lines you want to merge.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)