linux-kernel - Re: [PATCH v10] Regulator: Add Anatop regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120309095834.GM27213@game.jcrosoft.org>
Date:	Fri, 9 Mar 2012 10:58:34 +0100
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	"Ying-Chun Liu (PaulLiu)" <paul.liu@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linaro-dev@...ts.linaro.org, patches@...aro.org,
	Nancy Chen <Nancy.Chen@...escale.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Axel Lin <axel.lin@...il.com>
Subject: Re: [PATCH v10] Regulator: Add Anatop regulator driver

On 16:00 Fri 09 Mar     , Ying-Chun Liu (PaulLiu) wrote:
> (2012年03月08日 22:18), Jean-Christophe PLAGNIOL-VILLARD wrote:
> >> +static int __devexit anatop_regulator_remove(struct platform_device *pdev)
> >> +{
> >> +	struct regulator_dev *rdev = platform_get_drvdata(pdev);
> >> +	struct anatop_regulator *sreg = rdev_get_drvdata(rdev);
> >> +	kfree(sreg->name);
> >> +	regulator_unregister(rdev);
> > return from the unregister
> >> +	return 0;
> >> +}
> > Best Regards,
> > J.
> 
> Hi Jean-Christophe,
> 
> I've modify the patch based on your review. However, the last one cannot
> be made because regulator_unregister is void return.
so we have a issue here regulator_unregister MUST return an error conde

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/