linux-kernel - Re: [PATCH 1/2] powerpc/44x: Fix PCI MSI support for Maui APM821xx SoC and Bluestone board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+5PVA4sbuRsxO7Qv5RU8J+i1QcYGjS9O45ev-JRJz6B=i4Mfw@mail.gmail.com>
Date:	Fri, 9 Mar 2012 06:40:38 -0500
From:	Josh Boyer <jwboyer@...il.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Mai La <mla@....com>, Michael Neuling <mikey@...ling.org>,
	open-source-review@....com, Tirumala R Marri <tmarri@....com>,
	linux-kernel@...r.kernel.org,
	Josh Boyer <jwboyer@...ux.vnet.ibm.com>,
	Anton Blanchard <anton@...ba.org>,
	Paul Mackerras <paulus@...ba.org>,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 1/2] powerpc/44x: Fix PCI MSI support for Maui APM821xx
 SoC and Bluestone board

On Thu, Mar 8, 2012 at 10:35 PM, Benjamin Herrenschmidt
<benh@...nel.crashing.org> wrote:
> On Fri, 2012-03-09 at 10:17 +0700, Mai La wrote:
>> This patch consists of:
>> - Enable PCI MSI as default for Bluestone board
>> - Define number of MSI interrupt for Maui APM821xx SoC using in Bluestone board
>> - Fix returning ENODEV as finding MSI node
>> - Fix MSI physical high and low address
>> - Keep MSI data logically
>>
>> Signed-off-by: Mai La <mla@....com>
>> ---
>
>> index 7b4df37..c86231e 100644
>> --- a/arch/powerpc/sysdev/Kconfig
>> +++ b/arch/powerpc/sysdev/Kconfig
>> @@ -20,6 +20,12 @@ config PPC_MSI_BITMAP
>>       default y if FSL_PCI
>>       default y if PPC4xx_MSI
>>
>> +config PPC4xx_NR_MSI_IRQS
>> +     int "Number of PCI MSI interrupts"
>> +     depends on PCI_MSI && PPC4xx_MSI
>> +     default "4" if !APM821xx
>> +     default "8" if APM821xx
>> +
>
>  .../...
>
>> +#define NR_MSI_IRQS CONFIG_PPC4xx_NR_MSI_IRQS
>
> ARGH.
>
> We asked to -NOT MAKE THIS A COMPILE TIME OPTION-

Actually, I asked for basically exactly above.  I was _wrong_ in asking,
but it was asked for.

> CONFIG_foo is as bad as your previous ifdef, in fact you just added a
> useless config option here.
>
> Make that number dynamic. Count the entries in the device-tree (or add
> a property with the number in it, whatever you fancy the most) but make
> it something detected at RUNTIME !!!!!

My apologies Mai.  Ben is correct here and I should have thought more
about my suggestion before I made it.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/