linux-kernel - Re: [PATCH] x86: use enum instead of literals for trap values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJsxLF+hdk2Lk3AhsOR1KiCc6xfWZUpzCvJe4sgGO53abkhDQ@mail.gmail.com>
Date:	Sat, 10 Mar 2012 10:34:27 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Borislav Petkov <bp@...64.org>,
	Kees Cook <keescook@...omium.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	Andy Lutomirski <luto@....edu>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mike Frysinger <vapier@...too.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] x86: use enum instead of literals for trap values

Hi,

On Sat, Mar 10, 2012 at 12:13 AM, Ingo Molnar <mingo@...e.hu> wrote:
>> On 03/09/2012 10:52 AM, Steven Rostedt wrote:
>> > I agree too, except where does "XCP" come from? Is it short for
>> > "exception"?
>>
>> Yes, short for "exception".  I hate to admit it, but it comes from the
>> constants we used in the Transmeta microcode ;)
>
> Hm, were I to see 'X86_XCP_MC' for the first time I'd have no
> idea what it means. Really, lets not use random new
> abbreviations, lets use well-known patterns.
>
> Make it X86_TRAP_XX, it's both short and correct?

Yeah, my thoughts exactly. I don't think I have ever seen "XCP" before
so it really feels like an obscure new TLA to me.

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/