linux-kernel - Re: [PATCH v2] dmaengine: care sd_dma_address/len in dmaengine_prep_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F5B3707.1030504@metafoo.de>
Date:	Sat, 10 Mar 2012 12:12:07 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
CC:	Vinod Koul <vinod.koul@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Russell King <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dmaengine: care sd_dma_address/len in dmaengine_prep_slave_single()

On 03/09/2012 01:18 AM, Kuninori Morimoto wrote:
> 
> Hi Lars
> 
>> On 01/31/2012 02:13 AM, Kuninori Morimoto wrote:
>>> dmaengine_prep_slave_single() is helper macro of dmaengine.
>>> But it doesn't have sg_dma_address/len() settings which are required.
>>> And it used void *buf in parameter, but it should be dma_addr_t.
>>> This patch fixes up it.
>>>
>>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
>>
>> Hi,
>>
>> Any news regarding this patch? The dmaengine_prep_slave_single in upstream
>> is not really usable as it is right now.
> 
> Sorry. I have no news/update for this.
> I'm not good at IOMMU which was pointed by Russell.
> 
> Best regards
> ---
> Kuninori Morimoto


Well, he pointed out a minor and easy to fix flaw with the patch. But if you
don't want to resend the patch is it OK for you, if I resend the patch with the
flaw fixed? And is it OK, if I keep your Signed-off-by on that patch?

Thanks,
- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/