linux-kernel - Re: [PATCH v5 3/3] USB: ohci-nxp: Support for LPC32xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Mar 2012 21:53:51 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Roland Stigge <stigge@...com.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	kevin.wells@....com, linux-arm-kernel@...ts.infradead.org,
	arnd@...db.de
Subject: Re: [PATCH v5 3/3] USB: ohci-nxp: Support for LPC32xx

On Sat, Mar 10, 2012 at 09:49:55PM +0100, Wolfram Sang wrote:
> 
> > -static void isp1301_configure(void)
> > +static u16 i2c_read16(u8 subaddr)
> > +{
> > +	u16 data;
> > +
> > +	i2c_master_send(isp1301_i2c_client, &subaddr, 1);
> > +	i2c_master_recv(isp1301_i2c_client, (u8 *) &data, 2);
> > +
> > +	return data;
> > +}
> 
> Won't i2c_smbus_read_word_data(isp1301_i2c_client, reg) do?
> 
> And while we are at it: Could you also try replacing i2c_write() with
> i2c_smbus_write_byte_data(isp1301_i2c_client, reg, val)?
> 
> No need to recode it (and in general, those solutions will also work with SMBus
> for free)

"no need to recode it" means "no need to recode these already existing functions"

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)