linux-kernel - Re: [git pull] vfs fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwDsoJHGv03tcPgLb7DeFvdcDhmX0rfft8htMTd3aMPXQ@mail.gmail.com>
Date:	Sat, 10 Mar 2012 13:49:21 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] vfs fixes

On Sat, Mar 10, 2012 at 1:30 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> Jan Kara (2):
>      vfs: Fix missed wakeup in I_NEW handling

Christ. This one is too ugly to live.

I'm not pulling crap like this. It's f*^&ing stupid to take a lock,
calculate a bitqueue, and just generally be an absolute ass-hat about
things for waiting for a bit that is already set 99.999% of the time.

May I suggest just reverting that commit 250df6ed instead. It added
all these insane things for no good reason. The comment said they are
going away, but if they are just multiplying in ways like this, I
really think the damn thing needs to be reverted. Any change that
causes code like this is by definition not a good change.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/