linux-kernel - Re: [PATCH v3] mm: SLAB Out-of-memory diagnostics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120310031647.GA2988@t510.redhat.com>
Date:	Sat, 10 Mar 2012 00:16:48 -0300
From:	Rafael Aquini <aquini@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Randy Dunlap <rdunlap@...otime.net>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>, Rik van Riel <riel@...hat.com>,
	Josef Bacik <josef@...hat.com>,
	David Rientjes <rientjes@...gle.com>,
	Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH v3] mm: SLAB Out-of-memory diagnostics

Howdy Eric,

On Fri, Mar 09, 2012 at 04:23:39PM -0800, Eric Dumazet wrote:
> On Fri, 2012-03-09 at 17:27 -0300, Rafael Aquini wrote:
> > Following the example at mm/slub.c, add out-of-memory diagnostics to the
> > SLAB allocator to help on debugging certain OOM conditions.
> > 
> > An example print out looks like this:
> > 
> >   <snip page allocator out-of-memory message>
> >   SLAB: Unable to allocate memory on node 0 (gfp=0x11200)
> >     cache: bio-0, object size: 192, order: 0
> >     node 0: slabs: 3/3, objs: 60/60, free: 0
> 
> Should probably be :
> 
>    node: 0 slabs: 3/3, objs: 60/60, free: 0
>
 
No it shouldn't. Please refer to https://lkml.org/lkml/2012/3/7/242

The intent here was just to match slub's printout for its slab_out_of_memory 
node list slab components, as one can check on mm/slub.c:

2096                 printk(KERN_WARNING
2097                         "  node %d: slabs: %ld, objs: %ld, free: %ld\n",
2098                         node, nr_slabs, nr_objs, nr_free);


> > +		printk(KERN_WARNING
> > +			"  node %d: slabs: %ld/%ld, objs: %ld/%ld, free: %ld\n",
> 
> Probably should be :
> 		"  node: %d slabs: %ld/%ld, objs: %ld/%ld, free: %ld\n",
>

ditto.


Thanks for your feedback!

	Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/