linux-kernel - [PATCH] floppy: revert floppy disable halt warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120311093853.04f049c2@s6510.linuxnetplumber.net>
Date:	Sun, 11 Mar 2012 09:38:53 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Len Brown <len.brown@...el.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] floppy: revert floppy disable halt warning

Remove the stupid floppy disable halt warning. It is meaningless since
the API is local to floppy driver.  Our boot scripts check for the
floppy drive, and this causes the warning to trigger every time. This
confuses support, breaks automated tests that look for backtraces on
boot,  and adds no value.  

The message is being displayed to the wrong audience, it looks like it
was intended as a compromise of a long discussion on LKML about
supporting older x86 hardware; but users don't know or understand what
it is saying.

If you want to change halt handling then just fix
the floppy driver, don't whine about it.

Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

--- a/drivers/block/floppy.c	2012-03-11 09:27:52.866459327 -0700
+++ b/drivers/block/floppy.c	2012-03-11 09:28:29.286579201 -0700
@@ -1037,7 +1037,6 @@ static void floppy_disable_hlt(void)
 {
 	unsigned long flags;

-	WARN_ONCE(1, "floppy_disable_hlt() scheduled for removal in 2012");
 	spin_lock_irqsave(&floppy_hlt_lock, flags);
 	if (!hlt_disabled) {
 		hlt_disabled = 1;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/