linux-kernel - Re: [PATCH -next] regmap: add structs to fix build warnings when REGMAP is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120311115757.GD3233@opensource.wolfsonmicro.com>
Date:	Sun, 11 Mar 2012 11:57:58 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] regmap: add structs to fix build warnings when
 REGMAP is not enabled

On Fri, Mar 09, 2012 at 11:31:57AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...otime.net>
> 
> Fix build warnings when CONFIG_REGMAP is not enabled by providing
> struct forward references.

This isn't a great approach - you've put the forward declarations into
the ifdef which is at best needless (if they conflict with anything real
something went badly wrong) and for the register defaults the chances
are anything actually trying to use that stub needs to know about the
definition so the ifdef should be pulled further down the function.

I've done something better.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)