linux-kernel - Re: [PATCH] usb gadget: fix a section mismatch when compiling g_ffs with CONFIG_USB_FUNCTIONFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.wa0d4ki73l0zgt@mpn-glaptop>
Date:	Sun, 11 Mar 2012 14:51:46 +0100
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	linux-usb@...r.kernel.org,
	Lothar Waßmann <LW@...o-electronics.de>
Cc:	"Felipe Balbi" <balbi@...com>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb gadget: fix a section mismatch when compiling g_ffs
 with CONFIG_USB_FUNCTIONFS_ETH

On Sun, 11 Mar 2012 14:31:10 +0100, Lothar Waßmann <LW@...o-electronics.de> wrote:

> commit 28824b18ac4705e876a282a15ea0de8fc957551f:
> |Author: Michal Nazarewicz <m.nazarewicz@...sung.com>
> |Date:   Wed May 5 12:53:13 2010 +0200
> |
> |    USB: gadget: __init and __exit tags removed
> |
> |    __init, __initdata and __exit tags have have been removed from
> |    various files to make it possible for gadgets that do not use
> |    the __init/__exit tags to use those.
> obviously missed (at least) this case leading to a section mismatch in
> g_ffs.c when compiling with CONFIG_USB_FUNCTIONFS_ETH enabled.
>
> Signed-off-by: Lothar Waßmann <LW@...O-electronics.de>

Acked-by: Michal Nazarewicz <mina86@...a86.com>

> ---
>  drivers/usb/gadget/f_subset.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_subset.c b/drivers/usb/gadget/f_subset.c
> index c154064..3974bc9 100644
> --- a/drivers/usb/gadget/f_subset.c
> +++ b/drivers/usb/gadget/f_subset.c
> @@ -404,7 +404,7 @@ geth_unbind(struct usb_configuration *c, struct usb_function *f)
>   * Caller must have called @gether_setup().  Caller is also responsible
>   * for calling @gether_cleanup() before module unload.
>   */
> -int __init geth_bind_config(struct usb_configuration *c, u8 ethaddr[ETH_ALEN])
> +int geth_bind_config(struct usb_configuration *c, u8 ethaddr[ETH_ALEN])
>  {
>  	struct f_gether	*geth;
>  	int		status;


-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/