linux-kernel - Re: [PATCH] Makefile: fix error when gen TAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F5D9BCF.3030302@codeaurora.org>
Date:	Sun, 11 Mar 2012 23:46:39 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Yang Bai <hamo.by@...il.com>
CC:	mmarek@...e.cz, rostedt@...dmis.org, adobriyan@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Makefile: fix error when gen TAGS

On 3/11/2012 8:53 PM, Yang Bai wrote:
> scripts/tags.sh has a problem that it does not
> test which kind of tags we are generating and
> assumes tags. So when gen TAGS it shows:
>    GEN     TAGS
>    sed: can't read tags: No such file or directory
>    make: *** [TAGS] Error 2
>
> Signed-off-by: Yang Bai<hamo.by@...il.com>
> ---
>   scripts/tags.sh |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 833813a..ce94e34 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -168,7 +168,11 @@ exuberant()
>   	--regex-dotconfig='/^#?[[:blank:]]*(CONFIG_[[:alnum:]_]+)/\1/'
>
>   	# Remove structure forward declarations.
> -	LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' tags
> +	if [[ -e tags ]]; then
> +	    LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' tags
> +	else
> +	    LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' TAGS
> +	fi
>   }
>   

What does ctags --version print out for you? I'm not aware of exuberant 
tags outputting files called TAGS (although etags would do that and then 
this patch wouldn't make sense).

It would be nice if etags was updated to take care of this forward 
declaration removal. Care to send that patch?

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/