linux-kernel - Re: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120312.023659.22154618235290541.davem@davemloft.net>
Date:	Mon, 12 Mar 2012 02:36:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	santoshprasadnayak@...il.com
Cc:	sony.chacko@...gic.com, rajesh.borundia@...gic.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.

From: santosh prasad nayak <santoshprasadnayak@...il.com>
Date: Mon, 12 Mar 2012 14:45:38 +0530

> Subject: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.
> 
> Change the datatype of "ip_addr" to __be32 as 'ip' should be in
> big endian format.
> 
> Adapter needs "ip address" in big endian format stored at lower 32bit
> of req.word[1]. netxen_config_ipaddr() now receives 'ip' in big endian
> format. To satisfy adapter's need, use memcpy() to copy byte by byte
> of 'ip' into lower 32bit of req.word[1].
> 
> Mac address and serial number of adapter need to be in little endian format.
> Change the data type of the related  variables to __le32 / __le64 or cast it
> explicitly to __le32 / __le64 depending upon the requirement.

This looks a lot better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/