linux-kernel - Re: [PATCH] libata: disable runtime pm for hotpluggable port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Mar 2012 14:29:49 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Lin Ming <ming.m.lin@...el.com>
CC:	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>, jslaby@...e.cz,
	cwillu@...llu.com, jackdachef@...il.com
Subject: Re: [PATCH] libata: disable runtime pm for hotpluggable port

Hello.

On 12-03-2012 5:16, Lin Ming wrote:

> Currently, hotplug doesn't work if port is already runtime suspended.
> For now, we simply disable runtime pm for hotpluggable port.
> Later, we should add runtime pm support for hotpluggable port too.

> https://lkml.org/lkml/2012/2/19/70

> TODO: add similar hotpluggable port check for controllers other than AHCI.

> Reported-and-tested-by: Jiri Slaby<jslaby@...e.cz>
> Reported-and-tested-by: cwillu@...llu.com
> Reported-and-tested-by: jackdachef@...il.com
> Signed-off-by: Lin Ming<ming.m.lin@...el.com>
[...]

> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 3085bdc..ccf0282 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -209,8 +209,10 @@ enum {
>   	ATA_FLAG_SW_ACTIVITY	= (1<<  22), /* driver supports sw activity
>   					      * led */
>   	ATA_FLAG_NO_DIPM	= (1<<  23), /* host not happy with DIPM */
> +	ATA_FLAG_EXTERNAL	= (1<<  24), /* controller supports external SATA */
> +	ATA_FLAG_PLUGGABLE	= (1<<  25), /* port is hotpluggable */
>
> -	/* bits 24:31 of ap->flags are reserved for LLD specific flags */
> +	/* bits 26:31 of ap->flags are reserved for LLD specific flags */

    There's no need to use bits 24..25, I've freed up some lower order bits 
last year, removing unused values.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/