linux-kernel - Re: [patch] qnx6fs: silence a Sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e7d66e1ec32441e07e70f73581288dfd.squirrel@www.ontika.net>
Date:	Mon, 12 Mar 2012 11:47:56 +0100
From:	"Kai Bankett" <chaosman@...ika.net>
To:	"Dan Carpenter" <dan.carpenter@...cle.com>
Cc:	"Al Viro" <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] qnx6fs: silence a Sparse warning

Hi Dan,

thank you very much for the provided fix.
I've successfully applied and tested it. (well, did not expect much to
happen, but just to be on the safe side)
I will include it in my next version.

Thanks,

Kai

> Add a  __force to silence a sparse warning:
> 	fs/qnx6/inode.c:88:22: warning: cast to restricted __fs32
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/fs/qnx6/inode.c b/fs/qnx6/inode.c
> index e44012d..acf9241 100644
> --- a/fs/qnx6/inode.c
> +++ b/fs/qnx6/inode.c
> @@ -85,7 +85,7 @@ static int qnx6_get_block(struct inode *inode, sector_t
> iblock,
>
>  static int qnx6_check_blockptr(__fs32 ptr)
>  {
> -	if (ptr == ~(__fs32)0) {
> +	if (ptr == ~(__force __fs32)0) {
>  		printk(KERN_ERR "qnx6: hit unused blockpointer.\n");
>  		return 0;
>  	}
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/