linux-kernel - [PATCH] tile: remove a non-existing header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1331561930-14964-1-git-send-email-mchehab@redhat.com>
Date:	Mon, 12 Mar 2012 11:18:50 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	cmetcalf@...era.com, torvalds@...ux-foundation.org
Cc:	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Linux Edac Mailing List <linux-edac@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable@...nel.org
Subject: [PATCH] tile: remove a non-existing header

While testing some API changes at the EDAC core, I've tested the EDAC
drivers compilation on all supported architectures, including Tilera.

I noticed that Tilera upstream code has issues: it doesn't compile with
kernel 3.2:

In file included from include/linux/linkage.h:5,
                 from include/linux/kernel.h:13,
                 from include/linux/sched.h:55,
                 from arch/tile/kernel/asm-offsets.c:19:
/home/mchehab/redhat/trees/work/new_edac/arch/tile/include/asm/linkage.h:18:22: error: feedback.h: No such file or directory
make[1]: *** [arch/tile/kernel/asm-offsets.s] Error 1

Without it, it is not possible to compile anything on this archictecture
using this default configuration:
	./arch/tile/configs/tilegx_defconfig

Cc: stable@...nel.org
Signed-of-by: Mauro Carvalho Chehab <mchehab@...hat.com>

---

Btw, the ./arch/tile/configs/tilepro_defconfig doesn't compile even
with this fix. It fails at arch/tile/include/asm/atomic_64.h because
atomic64_t is never defined, but it is used there and on other places.

Also, while the edac_tile driver seems to be for both Tile GX and Tilepro
sub-archs, it is not included on tilegx_defconfig. It would make sense
to add it there, in order to make easier for people to test/use the
EDAC drivers.

---
 arch/tile/include/asm/linkage.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/tile/include/asm/linkage.h b/arch/tile/include/asm/linkage.h
index e121c39..43b298e 100644
--- a/arch/tile/include/asm/linkage.h
+++ b/arch/tile/include/asm/linkage.h
@@ -15,8 +15,6 @@
 #ifndef _ASM_TILE_LINKAGE_H
 #define _ASM_TILE_LINKAGE_H
 
-#include <feedback.h>
-
 #define __ALIGN .align 8
 
 /*
-- 
1.7.8

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/