linux-kernel - Re: [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1331566415.13200.14.camel@joe2Laptop>
Date:	Mon, 12 Mar 2012 08:33:35 -0700
From:	Joe Perches <joe@...ches.com>
To:	dedekind1@...il.com
Cc:	David Woodhouse <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg

On Mon, 2012-03-12 at 15:12 +0200, Artem Bityutskiy wrote:
> On Fri, 2012-03-09 at 10:49 -0800, Joe Perches wrote:
> > On Fri, 2012-03-09 at 13:53 +0200, Artem Bityutskiy wrote:
> > > OK, pushed these ones, although I think that mechanical D1->jffs2_dbg()
> > > conversion is not very useful and to make your patch-set worth the
> > > trouble you should do few more clean-up steps, like I suggested.
> > 
> > Do you want me to remove the D2/jffs2_dbg(2, ...) instances
> > or just eliminate the first arg to jffs2_dbg and keep the
> > current jffs2_dbg(2,...) instances?
> 
> Just remove. There were few other suggestions as well :-)

what about all the dbg_<foo> calls like
dbg_readinode(fmt, ...)?

I tentatively converted them to a bitmap
and a single jffs2_dbg(mask, fmt, ...)
but perhaps all of these could be deleted
too.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/