linux-kernel - Re: [PATCH 3/3] EDAC: Convert AMD EDAC pieces to use RAS printk buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120312162646.GB7255@aftab>
Date:	Mon, 12 Mar 2012 17:26:46 +0100
From:	Borislav Petkov <bp@...64.org>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Borislav Petkov <bp@...64.org>, Ingo Molnar <mingo@...e.hu>,
	EDAC devel <linux-edac@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] EDAC: Convert AMD EDAC pieces to use RAS printk
 buffer

On Mon, Mar 12, 2012 at 04:18:57PM +0000, Luck, Tony wrote:
> > This is an initial version of the patch which converts MCE decoding
> > facilities to use the RAS printk buffer. When there's no userspace agent
> > running (i.e., /sys/devices/system/ras/agent == 0), we fall back to the
> > default printk'ing into dmesg which is what we've been doing so far.
> 
> This looks unpleasant if your userspace agent set this sysfs file, and
> then dies (or gets killed).

Yeah, having a sysfs file like that felt unpleasant - I was hoping
someone would point me to a better solution...

> Perhaps you need some device file that the agent keeps open (so if the
> agent goes away, the kernel gets a "close" on the device to tell it
> to revert). But even with this sort of solution you would still have
> to worry about races.

Sounds better, especially the close-on-exit part. Please elaborate on
the races...

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/