linux-kernel - Re: [PATCH 1/2] HID: hid-lg4ff add support for G27 LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03eaca06ba2629f55144daa5a386c74b.squirrel@mungewell.org>
Date:	Mon, 12 Mar 2012 15:05:39 -0400
From:	simon@...gewell.org
To:	"Mark Brown" <broonie@...nsource.wolfsonmicro.com>
Cc:	simon@...gewell.org, "Jiri Kosina" <jkosina@...e.cz>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Michael Bauer" <michael@...auer.org>,
	"Michal Maly" <madcatxster@...il.com>
Subject: Re: [PATCH 1/2] HID: hid-lg4ff add support for G27 LEDs

>> The LEDs on the G27 are very much more specific, mounted on the yoke of
>> the gaming wheel.
>
>> Would this require the use/complexity of the LED subsystem?
>
> Well, it'd mean that applications that know how to drive LEDs will be
> able to use the LEDs on this wheel with less per device knowledge which
> seems like a useful thing and if someone wants to remap a LED to "new
> mail" or whatever that'll be easier (nethack has the mailer daemon
> deliver a scroll of mail!).

I'm not familiar with the LED subsystem, but my concerns would be that
this would add a whole load of code to implement.

Most of concern is the fact that the Logitech wheels are transitioned from
a 'simple' wheel when they are plugged in to an 'advanced' wheel, they
release/re-register with a different USB ID.

The port (for a lack of a better word) for controlling the LEDs is mixed
in with the FF and wheel configuration commands. All this is handled
within the hid-lg4ff driver (if FF is not enabled you just get the
'simple' wheel behaviour).

If you can point me at some (simple) implementations of the LED subsystem,
possibly with some guidance, we can look to see if the added complexity is
actually worth it.

I'd be pretty sure that other gaming controllers don't abstract their LEDs
via this subsystem,
Simon.

PS. I don't really care about email when screaming around Laguna Seca ;-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/