linux-kernel - Re: [PATCH] pinctrl: Include <linux/bug.h> to prevent compile errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbkoahUiB01srfBzm1Qh2RQPw5P6BjmouuLETAqfQY6_Q@mail.gmail.com>
Date:	Mon, 12 Mar 2012 20:44:42 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: Include <linux/bug.h> to prevent compile errors

On Fri, Mar 9, 2012 at 9:18 PM, Stephen Warren <swarren@...dotorg.org> wrote:

> Macros in <linux/pinctrl/machine.h> call ARRAY_SIZE(), the definition of
> which eventually calls BUILD_BUG_ON_ZERO(), which is defined in
> <linux/bug.h>. Include that so that every .c file using the pinctrl macros
> doesn't have to do that itself.

I get this part...

> Signed-off-by: Stephen Warren <swarren@...dotorg.org>
> ---
>  include/linux/pinctrl/machine.h |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/pinctrl/machine.h b/include/linux/pinctrl/machine.h
> index fee4349..012731a 100644
> --- a/include/linux/pinctrl/machine.h
> +++ b/include/linux/pinctrl/machine.h
> @@ -12,7 +12,9 @@
>  #ifndef __LINUX_PINCTRL_MACHINE_H
>  #define __LINUX_PINCTRL_MACHINE_H
>
> -#include "pinctrl-state.h"

?

> +#include <linux/bug.h>
> +
> +#include "pinctrl.h"

?

But I moved the states out of machine.h and pinctrl.h just so
that we shouldn't have to include pinctrl.h into machine.h?

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/