linux-kernel - Re: [ 29/68] kprobes: return proper error code from register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120312045749.GA15945@burratino>
Date:	Sun, 11 Mar 2012 23:57:49 -0500
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Prashanth K Nageshappa <prashanth@...ux.vnet.ibm.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Jason Baron <jbaron@...hat.com>
Subject: Re: [ 29/68] kprobes: return proper error code from register_kprobe()

Hi,

Greg KH wrote:

> 3.0-stable review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Prashanth Nageshappa <prashanth@...ux.vnet.ibm.com>
>
> commit f986a499ef6f317d906e6f6f281be966e1237a10 upstream.

Looks good for 3.2.y.

This is a pointless no-op in 3.0.y, since it doesn't include commit
bc81d48d13d8 (kprobes: Return -ENOENT if probe point doesn't exist,
2011-06-29).

[...]
> This patch fixes it by returning -EINVAL upon failure.
[...]
> @@ -1396,7 +1398,7 @@ out:
>  
>  	return ret;
>  
> -fail_with_jump_label:
> +cannot_probe:
>  	preempt_enable();
>  	jump_label_unlock();
>  	return -EINVAL;

Hope that helps,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/