linux-kernel - [PATCH] kexec: add further check to crashkernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F5EBAA7.50709@oracle.com>
Date:	Tue, 13 Mar 2012 11:10:31 +0800
From:	DuanZhenzhong <zhenzhong.duan@...cle.com>
To:	ebiederm@...ssion.com
CC:	kexec@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH] kexec: add further check to crashkernel

From: Zhenzhong Duan <zhenzhong.duan@...cle.com>

When add crashkernel=2M-256M, kernel don't give any warning.
This is misleading sometimes.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...cle.com>
---
 kernel/kexec.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/kernel/kexec.c b/kernel/kexec.c
index 7b08867..0a6d147 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1359,6 +1359,10 @@ static int __init parse_crashkernel_simple(char 		*cmdline,
 
 	if (*cur == '@')
 		*crash_base = memparse(cur+1, &cur);
+	else if (*cur != ' ' && *cur != '\0') {
+		pr_warning("crashkernel: unrecognized char\n");
+		return -EINVAL;
+	}
 
 	return 0;
 }
-- 1.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/