linux-kernel - RE: [PATCH 1/2] gpio/davinci: fix oops on unbanked gpio irq request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Mar 2012 22:39:30 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	"Nori, Sekhar" <nsekhar@...com>,
	Linus Walleij <linus.walleij@...ricsson.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>
Subject: RE: [PATCH 1/2] gpio/davinci: fix oops on unbanked gpio irq request

On Mon, 12 Mar 2012 18:54:53 +0000, "Nori, Sekhar" <nsekhar@...com> wrote:
> Hi Grant,
> 
> On Mon, Mar 12, 2012 at 23:21:35, Grant Likely wrote:
> > On Sun, 11 Mar 2012 18:16:11 +0530, Sekhar Nori <nsekhar@...com> wrote:
> > > Unbanked GPIO irq setup code was overwriting chip_data leading
> > > to the following oops on request_irq()
> > > 
> > > Unable to handle kernel paging request at virtual address febfffff
> > [...]
> > > Fix the issue.
> > 
> > Applied, but for next time "Fix the issue" isn't the most helpful commit text.
> > Please describe *how* you fixed the issue so that future commit readers have
> > more clues as to what this patch is doing.
> 
> Thanks for the feedback and noted for future. If it's not too much trouble, 
> can you change the last line in commit message to:
> 
> Fix the issue by making unbanked GPIO code not overwrite chip_data because 
> generic irq chip code uses it for its data structures. Instead use 
> handler_data to pass around GPIO controller information.

I've already pushed it out, so I cannot rebase it, but thanks for
taking me seriously.  :-D

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/